Skip to content

Fix isapprox for ScalarNonlinearFunction and comparison to Number #2934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
odow merged 2 commits into from
Feb 4, 2026
Merged

Fix isapprox for ScalarNonlinearFunction and comparison to Number #2934

odow merged 2 commits into from
Feb 4, 2026
+94 −12

Conversation

@odow
Copy link
Member

@odow odow commented Feb 4, 2026

Rabbit holes.

#2932 is failing because of a stack overflow on 32-bit

because isapprox uses recursion

but also comparisons to ::Number don't work.

@odow odow mentioned this pull request Feb 4, 2026
Open
@odow odow merged commit d0c0972 into master Feb 4, 2026
31 checks passed
@odow odow deleted the od/isapprox branch February 4, 2026 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blegat blegat blegat approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@odow @blegat