Fix double write when refusing hidden files in contents handler#1585
Merged
minrk merged 4 commits intojupyter-server:mainfrom Feb 13, 2026
Merged
Fix double write when refusing hidden files in contents handler#1585minrk merged 4 commits intojupyter-server:mainfrom
minrk merged 4 commits intojupyter-server:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix double write when refusing hidden files in contents handler
When a request targets a hidden file or directory and
allow_hiddenis false,the contents handler finishes a 404 response but continues execution and later
attempts to write again. This results in a secondary
RuntimeError: Cannot write() after finish().This change adds an early return after finishing the error response, preventing
further processing and avoiding the double write, without changing behavior.
Fixes #1563