Open
Conversation
added 2 commits
February 16, 2026 13:30
add session_id to gateway url
vincentye38
commented
Feb 19, 2026
| def __init__(self, **kwargs): | ||
| """Initialize a gateway kernel client.""" | ||
| super().__init__(**kwargs) | ||
| self.kernel_id = kernel_id |
Author
There was a problem hiding this comment.
Note: kernel_id is only used for constructing gateway websocket url.
vincentye38
commented
Feb 19, 2026
| GatewayClient.instance().kernels_endpoint, | ||
| url_escape(self.kernel_id), | ||
| "channels", | ||
| ) |
Author
There was a problem hiding this comment.
Note: I proposed to move ws_url initialization to kernel manager, and make ws_url as a property of kernel client. Because kernel manager is responsible to start kernel process, instantiate a kernel client to connect o the process. So it knows information of how to connect to the kernel process.
Kernel manager will set ws_url of kernel client after it creates the kernel client.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The kernel_id parameter caused the following exception when the ctor is called by
self.kernel_client = self.client(session=self.session)in KernelManager.init