Skip to content

Conversation

@Carreau
Copy link
Member

@Carreau Carreau commented Feb 8, 2026

with slight modification to install nbdime.,

@krassowski krassowski added the maintenance Maintenance action on the project label Feb 8, 2026
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not compile for me when tested on https://mybinder.org/v2/gh/Carreau/nbdime/binder?urlpath=tree

the compilation errors would be down to node setup issue?

#25 117.8   src/common/editor.ts:12:31 - error TS2307: Cannot find module '@jupyter/ydoc' or its corresponding type declarations.
#25 117.8 
#25 117.8   12 import { YFile, IYText } from '@jupyter/ydoc';
#25 117.8                                    ~~~~~~~~~~~~~~~
#25 117.8 
#25 117.8   src/patch/stringified.ts:71:19 - error TS2345: Argument of type 'string | undefined' is not assignable to parameter of type 'string'.
#25 117.8     Type 'undefined' is not assignable to type 'string'.
#25 117.8 
#25 117.8   71     ret = _indent(ret, level, indentFirst);
#25 117.8                        ~~~
#25 117.8 
#25 117.8   src/patch/stringified.ts:73:3 - error TS2322: Type 'string | undefined' is not assignable to type 'string'.
#25 117.8     Type 'undefined' is not assignable to type 'string'.
#25 117.8 
#25 117.8   73   return ret;
#25 117.8        ~~~~~~~~~~~
#25 117.8 
#25 117.8 
#25 117.8   Found 3 errors in 2 files.
#25 117.8 
#25 117.8   Errors  Files
#25 117.8        1  src/common/editor.ts:12
#25 117.8        2  src/patch/stringified.ts:71
#25 117.8 
#25 117.8 
#25 117.8 
#25 117.8    >  Lerna (powered by Nx)   Running target build for 3 projects failed
#25 117.8 
#25 117.8      Tasks not run because their dependencies failed or --nx-bail=true:
#25 117.8 
#25 117.8      - nbdime-jupyterlab:build
#25 117.8      - nbdime-webapp:build
#25 117.8 
#25 117.8      Failed tasks:
#25 117.8 
#25 117.8      - nbdime:build
#25 117.8 
#25 117.9   Traceback (most recent call last):
#25 117.9     File "/srv/conda/envs/notebook/lib/python3.11/site-packages/pip/_vendor/pyproject_hooks/_in_pro

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seem to be doing about the same, except it's using a super complicated python script, instead of setting bash -x to each which commands are ran.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I am not opinionated on the language, whichever does the job.

@Carreau
Copy link
Member Author

Carreau commented Feb 10, 2026

@vidartf you are a maintainer of pytest_tornado, it has not been released in 6 years but is incompatible with latest setuptools, should it still be used ?

@krassowski krassowski changed the title Copy binder config from jupyter_collaboration; Add binder config Feb 10, 2026
@Carreau Carreau changed the title Add binder config Add binder config, drop pytest-tornado Feb 10, 2026
@Carreau
Copy link
Member Author

Carreau commented Feb 10, 2026

Ok, it should work now; I also drop pytest-tornado which is broken with latest setuptook and has not been released in 6 years.

Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Carreau!

@krassowski krassowski merged commit e685627 into jupyter:main Feb 10, 2026
19 checks passed
@Carreau
Copy link
Member Author

Carreau commented Feb 10, 2026

thanks for the review and merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Maintenance action on the project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants