-
Notifications
You must be signed in to change notification settings - Fork 186
Add binder config, drop pytest-tornado #807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
krassowski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not compile for me when tested on https://mybinder.org/v2/gh/Carreau/nbdime/binder?urlpath=tree
the compilation errors would be down to node setup issue?
#25 117.8 src/common/editor.ts:12:31 - error TS2307: Cannot find module '@jupyter/ydoc' or its corresponding type declarations.
#25 117.8
#25 117.8 12 import { YFile, IYText } from '@jupyter/ydoc';
#25 117.8 ~~~~~~~~~~~~~~~
#25 117.8
#25 117.8 src/patch/stringified.ts:71:19 - error TS2345: Argument of type 'string | undefined' is not assignable to parameter of type 'string'.
#25 117.8 Type 'undefined' is not assignable to type 'string'.
#25 117.8
#25 117.8 71 ret = _indent(ret, level, indentFirst);
#25 117.8 ~~~
#25 117.8
#25 117.8 src/patch/stringified.ts:73:3 - error TS2322: Type 'string | undefined' is not assignable to type 'string'.
#25 117.8 Type 'undefined' is not assignable to type 'string'.
#25 117.8
#25 117.8 73 return ret;
#25 117.8 ~~~~~~~~~~~
#25 117.8
#25 117.8
#25 117.8 Found 3 errors in 2 files.
#25 117.8
#25 117.8 Errors Files
#25 117.8 1 src/common/editor.ts:12
#25 117.8 2 src/patch/stringified.ts:71
#25 117.8
#25 117.8
#25 117.8
#25 117.8 > Lerna (powered by Nx) Running target build for 3 projects failed
#25 117.8
#25 117.8 Tasks not run because their dependencies failed or --nx-bail=true:
#25 117.8
#25 117.8 - nbdime-jupyterlab:build
#25 117.8 - nbdime-webapp:build
#25 117.8
#25 117.8 Failed tasks:
#25 117.8
#25 117.8 - nbdime:build
#25 117.8
#25 117.9 Traceback (most recent call last):
#25 117.9 File "/srv/conda/envs/notebook/lib/python3.11/site-packages/pip/_vendor/pyproject_hooks/_in_pro
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is another template for reference: https://github.com/jupyterlab/extension-template/blob/main/template/%7B%25%20if%20has_binder%20%25%7Dbinder%7B%25%20endif%20%25%7D/postBuild.jinja
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seem to be doing about the same, except it's using a super complicated python script, instead of setting bash -x to each which commands are ran.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I am not opinionated on the language, whichever does the job.
|
@vidartf you are a maintainer of pytest_tornado, it has not been released in 6 years but is incompatible with latest setuptools, should it still be used ? |
|
Ok, it should work now; I also drop pytest-tornado which is broken with latest setuptook and has not been released in 6 years. |
krassowski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Carreau!
|
thanks for the review and merging |
with slight modification to install nbdime.,