Skip to content

Fix shared document interface #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martinRenou merged 5 commits into from
Feb 6, 2025
Merged

Fix shared document interface #677

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
469a5ac
Fix shared document interface
arjxn-py Feb 6, 2025
752ab17
Merge branch 'main' into fix-shared-document-interface
arjxn-py Feb 6, 2025
d3fd92a
getSource returns `JSONObject`
arjxn-py Feb 6, 2025
dadf3c4
Merge branch 'main' into fix-shared-document-interface
arjxn-py Feb 6, 2025
c33410f
change type for setSource too
arjxn-py Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/schema/src/interfaces.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,9 @@ export interface IJupyterCadDoc extends YDocument<IJupyterCadDocChange> {
setOutput(key: string, value: IPostResult): void;
removeOutput(key: string): void;

getSource(): JSONObject;
setSource(value: JSONObject | string): void;

getMetadata(key: string): string | undefined;
setMetadata(key: string, value: string): void;
removeMetadata(key: string): void;
Expand Down
Loading