Skip to content

Widget with toolbar and sidepanel in cell output#679

Merged
martinRenou merged 17 commits intojupytercad:mainfrom
arjxn-py:cell-output-document-widget
Feb 11, 2025
Merged

Widget with toolbar and sidepanel in cell output#679
martinRenou merged 17 commits intojupytercad:mainfrom
arjxn-py:cell-output-document-widget

Conversation

@arjxn-py
Copy link
Member

@arjxn-py arjxn-py commented Feb 10, 2025

@arjxn-py arjxn-py added the enhancement New Feature or improvement label Feb 10, 2025
@arjxn-py arjxn-py force-pushed the cell-output-document-widget branch from 78b4c01 to 7aa3712 Compare February 10, 2025 11:00
@arjxn-py arjxn-py marked this pull request as draft February 10, 2025 11:03
@arjxn-py arjxn-py force-pushed the cell-output-document-widget branch from 0fc0ace to 9f9a5e7 Compare February 10, 2025 12:10
@arjxn-py arjxn-py force-pushed the cell-output-document-widget branch from 1f48340 to 470888f Compare February 10, 2025 12:46
@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2025

Integration tests report: appsharing.space

@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2025

Preview PR at appsharing.space

@arjxn-py arjxn-py force-pushed the cell-output-document-widget branch from a888777 to 4cc69f5 Compare February 10, 2025 16:51
@arjxn-py arjxn-py force-pushed the cell-output-document-widget branch from adfea82 to c578730 Compare February 10, 2025 16:52
@arjxn-py arjxn-py force-pushed the cell-output-document-widget branch from a1e60d5 to 83131ac Compare February 11, 2025 06:42
@arjxn-py arjxn-py force-pushed the cell-output-document-widget branch from 9bca531 to 674c329 Compare February 11, 2025 10:33
@arjxn-py arjxn-py force-pushed the cell-output-document-widget branch from 8f08394 to e15fdca Compare February 11, 2025 11:30
@arjxn-py arjxn-py marked this pull request as ready for review February 11, 2025 11:30
@trungleduc
Copy link
Member

Thanks @arjxn-py, the failed UI tests are not related?

@arjxn-py
Copy link
Member Author

Thanks @arjxn-py, the failed UI tests are not related?

It could be related, i'm looking into it

@martinRenou
Copy link
Member

Seems related, the toolbar now shows up in the cell outputs, but it does not show up anymore in the normal case

@arjxn-py arjxn-py force-pushed the cell-output-document-widget branch from bd2e9ef to 5c21b38 Compare February 11, 2025 13:19
@arjxn-py
Copy link
Member Author

Bot please update snapshots.

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🚀 !!

@martinRenou martinRenou merged commit f5c86a2 into jupytercad:main Feb 11, 2025
10 checks passed
@arjxn-py arjxn-py deleted the cell-output-document-widget branch April 8, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New Feature or improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants