Open
Conversation
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
paugier
force-pushed
the
add-MercurialRepoProvider
branch
2 times, most recently
from
f3a67a4 to
87bb67a
Compare
|
I'm not familiar with the Jupyter context, but the Mercurial side of it looks fine to me. |
paugier
force-pushed
the
add-MercurialRepoProvider
branch
2 times, most recently
from
68b0500 to
eb4890e
Compare
Author
|
It would be great if someone can have a look at this PR? |
consideRatio
added
code:html/js/css
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This PR depends on an unreleased version of repo2docker (jupyterhub/repo2docker#950)
It implements a Mercurial repo provider (and therefore fixes #1148).
I tried to copy the GitRepoProvider but I'm not sure about how are used the different methods (and I don't know Javascript!).
@gracinet You may be interested to check what I did.