Skip to content

add Gateway API support via httpRoute#2058

Open
minrk wants to merge 1 commit intojupyterhub:mainfrom
minrk:gateway
Open

add Gateway API support via httpRoute#2058
minrk wants to merge 1 commit intojupyterhub:mainfrom
minrk:gateway

Conversation

@minrk
Copy link
Member

@minrk minrk commented Jan 27, 2026

example, migrate

ingress:
  enabled: true
  hosts:
    - staging.mybinder.org
  ingressClassName: nginx

to

httpRoute:
  enabled: true
  hostnames:
    - staging.mybinder.org
  parentRefs:
    - kind: Gateway
      name: gateway-name

tls is handled on the Gateway instead of the Route, so there is no substitute for the tls config within this chart, that becomes entirely out of scope for the chart.

{{- toYaml . | nindent 4 }}
{{- end }}
spec:
{{- with $route.parentRefs }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate this naming over z2jh's current naming that references a gateway instead of parentRefs, considering if we should align z2jh with this

Copy link
Member

@manics manics Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had that thought too! The current Z2JH values have already been released though, so it would either be a breaking change, or require more complicated logic to provide backwards compatibility.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I should have commented my reasoning here. This is based on having done a deployment with jupyterhub and prometheus/grafana, and I like the prometheus/grafana approach better, since it is a more straightforward passthrough of the specs.

Theirs do expose much more of the route to allow for other Gateway API versions, route types, rules, but I thought that was overkill for us for now, so this is a bit in between theirs and the one in z2jh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants