fix: serve launcher icons for svg and png#548
Merged
jnywong merged 3 commits intojupyterhub:mainfrom Feb 16, 2026
Merged
Conversation
1 task
Member
|
Hi @chengs, thanks for your contribution. We fixed some of the linkchecker CI errors that failed that were unrelated to this PR, and everything looks good now. Thank you for adding the tests for this feature, much appreciated. |
jnywong
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a permanent fix for serving launcher icons based on file type (e.g. SVG and PNG), with tests + docs.
This PR is intended as a permanent fix replacing #527.