Check signing and verification key type for ECDSA algorithm#688
Merged
Check signing and verification key type for ECDSA algorithm#688
Conversation
anakinj
force-pushed
the
check-ecdsa-key-type
branch
from
a2d7e3f to
3ef1c4c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently the methods raise method missing errors, like in #677
While at it I removed the
expect(OpenSSL.errors).to be_emptyassertion. As I think we have moved past the historical reasons to care about it.Checklist
Before the PR can be merged be sure the following are checked: