fix: use macOS DMG source with JS stubs, update to v1.1.1200#87
Open
Programmerino wants to merge 1 commit intok3d3:mainfrom
Open
fix: use macOS DMG source with JS stubs, update to v1.1.1200#87Programmerino wants to merge 1 commit intok3d3:mainfrom
Programmerino wants to merge 1 commit intok3d3:mainfrom
Conversation
Major changes: - Switch from Windows installer to macOS DMG (more reliable extraction) - Replace Rust native bindings (patchy-cnb) with simple JavaScript stubs - Update to Claude Desktop v1.1.1200 - Add Linux platform detection for Claude Code - Fix tray icon theme detection for dark/light modes - Simplify build process (no Rust compilation needed) The previous Rust-based approach required compilation and had issues with the tray menu patches injecting 'await' outside async contexts, causing SyntaxError on startup. The JS stub approach matches what claude-desktop-debian uses and is simpler to maintain.
092def3 to
22cebe1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes Claude Desktop on Linux by switching to a simpler, working approach:
Changes
Why?
The previous Rust-based
patchy-cnbapproach had issues:awaitoutside async contexts, causingSyntaxError: Unexpected token 'new'on startupThe JS stub approach matches what claude-desktop-debian uses and is proven to work.
Testing
Tested on NixOS - app starts, logs in, connects to MCP servers, and downloads Claude Code successfully.
Stats