Skip to content

Conversation

@popsiclexu
Copy link
Contributor

@popsiclexu popsiclexu commented Jan 14, 2025

Closes #

📑 Description

add OpenAPI shcema to custom rest backend tutorial
Relative PR: k8sgpt-ai/k8sgpt#1228

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

@netlify
Copy link

netlify bot commented Jan 14, 2025

Deploy Preview for meek-marigold-103c48 ready!

Name Link
🔨 Latest commit 75bda29
🔍 Latest deploy log https://app.netlify.com/sites/meek-marigold-103c48/deploys/67cebddb55307a000878d62f
😎 Deploy Preview https://deploy-preview-135--meek-marigold-103c48.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PixelRobots
Copy link
Contributor

Hey @popsiclexu You are missing DCO from this pull request. Can you please look at the instructions below to sign off this commit.

To sign off the last commit you made, you can use

git commit --amend --signoff

You can also automate signing off your commits by adding the following to your .zshrc or .bashrc:

git() {
  if [ $# -gt 0 ] && [[ "$1" == "commit" ]] ; then
     shift
     command git commit --signoff "$@"
  else
     command git "$@"
  fi
}

@popsiclexu popsiclexu force-pushed the feat/customrest-doc branch 2 times, most recently from c7f0f33 to 4d155a2 Compare March 6, 2025 02:23
@popsiclexu
Copy link
Contributor Author

@PixelRobots I have already signed the commit. Thanks for pointing it out!

@PixelRobots
Copy link
Contributor

Hey thanks for that. It looks like the commit also needs a verified signature before I can merge it.

Below you will find some instructions on how this can be fixed.

1. Check If Your Commits Are Signed

Run this in your terminal:

git log --show-signature

If your commits are not signed or marked as unverified, proceed to the next step.

2. Set Up GPG or SSH Key Signing

For GPG Signing (Recommended)

  1. Generate a GPG Key (if you don’t have one)

    gpg --full-generate-key
    • Choose RSA and RSA.
    • Select a key size of at least 4096 bits.
    • Set an expiration date (or choose no expiration).
    • Enter your GitHub email when prompted.
  2. List Your GPG Keys

    gpg --list-secret-keys --keyid-format=long

    Copy the GPG key ID from the output.

  3. Export Your Public Key

    gpg --armor --export YOUR_KEY_ID
    • Copy the output and add it to GitHub under:
      GitHub Settings > SSH and GPG keys > New GPG Key.
  4. Tell Git to Use Your GPG Key

    git config --global user.signingkey YOUR_KEY_ID
    git config --global commit.gpgsign true
  5. Sign Your Commits

    git commit -S -m "Your commit message"
  6. Push the Signed Commit

    git push origin YOUR_BRANCH

For SSH Signing (Alternative)

If you're using SSH, follow [GitHub’s SSH commit signing guide](https://docs.github.com/en/authentication/managing-commit-signature-verification/generating-a-new-ssh-key-for-commit-signing).

After signing, your commits should show as "Verified" in GitHub and I will be able to merge.

Thanks again for your contribution.

@popsiclexu popsiclexu force-pushed the feat/customrest-doc branch from 4d155a2 to ef16809 Compare March 10, 2025 10:21
Signed-off-by: popsiclexu <ZhenxueXu@gmail.com>
@popsiclexu popsiclexu force-pushed the feat/customrest-doc branch from ef16809 to 75bda29 Compare March 10, 2025 10:24
@popsiclexu
Copy link
Contributor Author

@PixelRobots I have already signed the commit. Thanks for your help.

@PixelRobots PixelRobots self-requested a review March 11, 2025 19:51
Copy link
Contributor

@PixelRobots PixelRobots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PixelRobots PixelRobots merged commit 21181c5 into k8sgpt-ai:main Mar 11, 2025
6 checks passed
@popsiclexu popsiclexu deleted the feat/customrest-doc branch March 12, 2025 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants