test: adding os-matrix for unit tests#39
Open
axel7083 wants to merge 1 commit intok9withabone:mainfrom
Open
Conversation
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When trying to investigate #38 I find out that the problem was only occurring on Windows.
The problem is occurring in the code below, the
is_absoluteis platform specific.compose_spec_rs/src/service/volumes.rs
Lines 310 to 314 in 1c6924b
Quoting the rust documentation
Source https://doc.rust-lang.org/std/path/struct.Path.html
The
ContainerPathis always POSIX, so the is_absolute cannot be used on it, since on windows it would failsContext
This PR does not fix the problem, as I am not familiar with the code, and with the numerous usage of the
AbsolutePathstruct I don't want to risk to break everything!This PR is adding an os-matrix for testing. (Today it fails, but if #38 is fixed, a simple rebase should be enough)