add support for oauth with schema registry#1645
add support for oauth with schema registry#1645KyriosGN0 wants to merge 8 commits intokafbat:mainfrom
Conversation
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
There was a problem hiding this comment.
Hi KyriosGN0! 👋
Welcome, and thank you for opening your first PR in the repo!
Please wait for triaging by our maintainers.
Please take a look at our contributing guide.
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
|
the failed test is passing locally |
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
|
hey @germanosin, about the docs PR, should i open it in parallel ? |
| String clientSecret; | ||
|
|
||
| Boolean tokenCacheEnabled = true; | ||
| Integer tokenRefreshBufferSeconds = 60; // Refresh token N seconds before expiry |
| * Stores tokens with expiration time and provides automatic expiration checking. | ||
| */ | ||
| @Slf4j | ||
| public class OAuthTokenCache { |
There was a problem hiding this comment.
Could we use just Caffeine for it?
There was a problem hiding this comment.
@germanosin do you mean https://docs.spring.io/spring-framework/reference/integration/cache/store-configuration.html#cache-store-configuration-caffeine or just the pure Caffeine?
There was a problem hiding this comment.
We use pure caffeine inside for example
https://github.com/kafbat/kafka-ui/blob/main/api/src/main/java/io/kafbat/ui/service/PollingCursorsStorage.java#L19
…efresh buffer Signed-off-by: AvivGuiser <avivguiser@gmail.com>
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
closes #1575
What changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)