Skip to content

CFG-64 removes weird tests #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tamarakaufler wants to merge 2 commits into
base: karhoo
Choose a base branch
from
Open

CFG-64 removes weird tests #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9cdfa84
CFG-64 removes weirdly failing tests
Aug 16, 2019
8a4909a
CFG-64 typo fix
Aug 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 0 additions & 23 deletions fixtures/semantic_api.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,29 +531,6 @@
"type": "boolean"
},
"x-proto-tag": 13
},
"test_map_scalar_float": {
"type": "object",
"additionalProperties": {
"type": "number",
"format": "float"
},
"x-proto-tag": 14
},
"test_map_scalar_double": {
"type": "object",
"additionalProperties": {
"type": "number",
"format": "double"
},
"x-proto-tag": 15
},
"test_map_scalar_double_none": {
"type": "object",
"additionalProperties": {
"type": "number"
},
"x-proto-tag": 16
}
}
}
Expand Down
3 changes: 0 additions & 3 deletions fixtures/semantic_api.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,9 +209,6 @@ message TestModel {
map<string, TestModel> test_map_object = 11;
map<string, string> test_map_scalar = 12;
map<string, bool> test_map_scalar_bool = 13;
map<string, float> test_map_scalar_float = 14;
map<string, double> test_map_scalar_double = 15;
map<string, double> test_map_scalar_double_none = 16;
google.protobuf.DoubleValue test_num_value = 5;
google.protobuf.DoubleValue test_numer_value = 6;
google.protobuf.StringValue test_string_value = 8;
Expand Down
2 changes: 1 addition & 1 deletion openapi.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ func refDef(name, ref string, index int, defs map[string]*Items) string {
// this may not have been caught earlier
def, ok := defs[path.Base(ref)]
if ok {
// if it is an array type, protocomplex indstead of just using the referenced type
// if it is an array type, protocomplex instead of just using the referenced type
if def.Type == "array" {
return protoComplex(def, def.Type.(string), "", name, defs, &index, 0)
}
Expand Down