Skip to content
This repository was archived by the owner on Jun 28, 2024. It is now read-only.

kubernetes: add agnhost command in pod yaml#5616

Open
LindaYu17 wants to merge 1 commit intokata-containers:mainfrom
LindaYu17:dev
Open

kubernetes: add agnhost command in pod yaml#5616
LindaYu17 wants to merge 1 commit intokata-containers:mainfrom
LindaYu17:dev

Conversation

@LindaYu17
Copy link

@LindaYu17 LindaYu17 commented Apr 20, 2023

add container command in pod spec for better port this test to Confidential containers.

@katacontainersbot katacontainersbot added the size/tiny Smallest and simplest task label Apr 21, 2023
@fidencio
Copy link
Member

fidencio commented May 22, 2023

@LindaYu17, thanks a lot for the contribution.

Right now we're in a weird situation with the kubernetes tests, as we've those running as part of two different CIs.
Your patch will be applied and it'll work for the Jenkins CI, but we also want to have this one for our GitHub Action jobs.
With this in mind, would it be possible for you to open the very same PR against https://github.com/kata-containers/kata-containers/tree/main/tests/integration/kubernetes ?

fidencio
fidencio approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @LindaYu17!

fidencio
fidencio approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @LindaYu17!

@LindaYu17
Copy link
Author

LindaYu17 commented May 23, 2023

@LindaYu17, thanks a lot for the contribution.

Right now we're in a weird situation with the kubernetes tests, as we've those running as part of two different CIs. Your patch will be applied and it'll work for the Jenkins CI, but we also want to have this one for our GitHub Action jobs. With this in mind, would it be possible for you to open the very same PR against https://github.com/kata-containers/kata-containers/tree/main/tests/integration/kubernetes ?

@fidencio Thank you for the review, here's the PR on kata-containers project : kata-containers/kata-containers#6929

@fidencio
Copy link
Member

fidencio commented May 24, 2023

/test

@fidencio
Copy link
Member

fidencio commented May 24, 2023

/cc @arronwy

arronwy
arronwy approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@arronwy arronwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LindaYu17 LGTM!

@LindaYu17 LindaYu17 changed the title kubernetes: add agnhost command in pod yaml k8s: add agnhost command in pod yaml Jun 2, 2023
@LindaYu17 LindaYu17 changed the title k8s: add agnhost command in pod yaml kubernetes: add agnhost command in pod yaml Jun 2, 2023
@LindaYu17 LindaYu17 force-pushed the dev branch 4 times, most recently from 638b3b4 to b17bd7e Compare June 5, 2023 06:04
@LindaYu17
kubernetes: add agnhost command in pod yaml
ef07d63 
add agnhost command in pod yaml file
Fixes: kata-containers#5619

Signed-off-by: Linda Yu <linda.yu@intel.com>
@katacontainersbot katacontainersbot added size/small Small and simple task and removed size/tiny Smallest and simplest task labels Jun 5, 2023
@chavafg
Copy link
Contributor

chavafg commented Jun 10, 2023

/test

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@fidencio fidencio fidencio approved these changes

@arronwy arronwy arronwy approved these changes

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

size/small Small and simple task

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@LindaYu17 @fidencio @chavafg @arronwy @katacontainersbot