This repository was archived by the owner on Jun 28, 2024. It is now read-only.
CCv0: improve debugability of SEV/SNP tests#5710
Open
wainersm wants to merge 5 commits intokata-containers:CCv0from
Open
CCv0: improve debugability of SEV/SNP tests#5710wainersm wants to merge 5 commits intokata-containers:CCv0from
wainersm wants to merge 5 commits intokata-containers:CCv0from
Conversation
The SEV and SNP tests sometimes fail on CI and it is hard to determine what went wrong because they don't print debug messages. This changed the tests so that they behave like many others: print the system's logs since the test's begin time. Fixes kata-containers#5708 Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
The setup() function of SEV and SNP tests execute some clean up routines to get rid of resources left by the previous test. In reality the good practice is to have the test remove its used resources on teardown. Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Print the running pods description as well. Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Contributor
Author
|
/test-snp |
Contributor
Author
|
The snp fail: |
stevenhorsman
approved these changes
Jul 13, 2023
Member
stevenhorsman
left a comment
stevenhorsman
left a comment
There was a problem hiding this comment.
LGTM. Thanks @wainersm!
Print the containerd journal since the start of the test. Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
katacontainersbot
added
size/tiny
Contributor
Author
|
Added the do-not-merge label because we will use this PR to debug the problem. |
Contributor
Author
|
/test-snp |
katacontainersbot
added
size/medium
Contributor
Author
|
/test-snp |
Contributor
Author
|
/test-snp |
|
We might need to adjust the debug level of containerd to get the really juicy messages. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's print debug information on the SEV/SNP tests as currently we are left clueless about some fails.
Fixes #5708