fix: Add height=100% to container if height is set to auto#13
Open
clinton-encord wants to merge 1 commit intokatspaugh:mainfrom
Open
fix: Add height=100% to container if height is set to auto#13clinton-encord wants to merge 1 commit intokatspaugh:mainfrom
clinton-encord wants to merge 1 commit intokatspaugh:mainfrom
Conversation
Author
|
Hi @katspaugh ! Could you run the workflows here? |
Owner
|
@clinton-encord sorry for the late reply! I read the PR I'm not sure I understand that the main issue that the outer container div that the React wrapper creates doesn't automatically inherit the height of its parent. So perhaps we should just always set its height to 100%? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When passing
height='auto'to the WavesurferPlayer, it is not actually able to take automatically adjust height because the container defined inWavesurferPlayerdoesn't have a height.So realistically, someone who uses
WavesurferPlayerwould expect the player to take the height of its player container.i.e.