fix: set the interim workspace phase as Scheduling#3815
Open
cnvergence wants to merge 3 commits intokcp-dev:mainfrom
Open
fix: set the interim workspace phase as Scheduling#3815cnvergence wants to merge 3 commits intokcp-dev:mainfrom
cnvergence wants to merge 3 commits intokcp-dev:mainfrom
Conversation
Contributor
|
Skipping CI for Draft Pull Request. |
kcp-ci-bot
added
do-not-merge/work-in-progress
Member
Author
|
/test pull-kcp-test-e2e-sharded |
kcp-ci-bot
added
size/XS
kcp-ci-bot
removed
the
do-not-merge/work-in-progress
cnvergence
force-pushed
the
fix-flaky-wstype-e2e
branch
from
537382f to
9090257
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Member
Author
|
/retest |
cnvergence
added
kind/flake
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This aims to fix the flake in the workspace not being ready in the initial phase in the e2e test.
Sets the initial phase in the workspace metadata reconciler during workspace creation to "Scheduling", suspecting the clue was the race conditions between different reconcilers, then it should transition to "Initializing" and "Ready" properly.
What Type of PR Is This?
/kind flake
Related Issue(s)
Fixes #3811
Release Notes