Make note of changes to macOS leveldb install. #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdrag0n
requested changes
Feb 17, 2021
Owner
kdrag0n
left a comment
kdrag0n
left a comment
There was a problem hiding this comment.
Thanks for the contribution, just a minor detail to fix.
| | FreeBSD | `pkg install leveldb` | | ||
|
|
||
| > At the time of writing this note, macOS's package installer *brew* requires a different command to install leveldb. | ||
| `brew install --build-from-source leveldb` |
Owner
There was a problem hiding this comment.
Please edit the macOS command to add this argument instead. It can be reverted if/when the upstream issue is fixed rather than adding a separate note. Don't worry about alignment in the table for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.