Include the number of long and short trades in the output report #1317
Open
bravegag wants to merge 4 commits intokernc:masterfrom
Open
Include the number of long and short trades in the output report #1317bravegag wants to merge 4 commits intokernc:masterfrom
bravegag wants to merge 4 commits intokernc:masterfrom
Conversation
Owner
|
We maintain it reasonably simple and convenient to compute many custom stats on your own, e.g.: def long_trades(stats):
return (stats._trades.Size > 0).sum()
def long_short_ratio(stats):
is_long = stats._trades.Size > 0
return is_long.sum() / (~is_long).sum()
def win_rate_long(stats):
is_long = stats._trades.Size > 0
return (stats._trades[is_long].PnL > 0).mean()Your PR introduces 5 new items into the stats series, increasing its viewable/scroll length for everyone. I wonder if we shouldn't rather add an try:
return super().__getitem__(key)
except KeyError:
# Fallback to extended stats lookup
return self['_extended_stats'][key]🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1309 providing more context on explaining the PnL in terms of number of long and short positions.
Just to give a bit of context why this is so useful, I have a backtesting model iterator that runs each backtest and concatenates all the reports together into a final dataframe which I then export to excel for slicing and dicing the best model. So each of these stats report outputs is a row.
The output report now is the following, for example, in this example I can see that there is a big imbalance or bias towards bulls. It also reveals the hit rate per side and a quick long to shorts ratio: