Add test to make sure extra Literal packets are not allowed#205
Open
michalz-zoom wants to merge 1 commit intomasterfrom
Open
Add test to make sure extra Literal packets are not allowed#205michalz-zoom wants to merge 1 commit intomasterfrom
michalz-zoom wants to merge 1 commit intomasterfrom
Conversation
OpenPGP.js (different PGP library, unrelated to Keybase or KBPGP) recently had an issue where extraneous compressed Literal packet would override the message returned during verification, even if it was not signed. KBPGP always reads armored PGP buffers to end and rejects packet lists where there is more than one Literal packet. Also, "signers" are a property of the literal packet itself, and we always check the signer of the literal packet we are about to return cleartext data from.
michalz-zoom
force-pushed
the
dev/michal/pgp-spoofing-test
branch
from
866d20a to
7dcdca6
Compare
Member
Author
|
@heronhaye can you take a look? Is it worth to merge this here? Hope this works - too bad we don't have CI here. I still need to re-run this branch as is, because my |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenPGP.js (different PGP library, unrelated to Keybase or KBPGP) recently had an issue where extraneous compressed Literal packet would override the message returned during verification, even if it was not signed.
KBPGP always reads armored PGP buffers to end and rejects packet lists where there is more than one Literal packet. Also, "signers" are a property of the literal packet itself, and we always check the signer of the literal packet we are about to return cleartext data from.