This repository was archived by the owner on Nov 24, 2021. It is now read-only.
Fix requireOptional error and nodemailer require, fix #15#16
Closed
neagle wants to merge 1 commit intokeystonejs:masterfrom
Closed
Fix requireOptional error and nodemailer require, fix #15#16neagle wants to merge 1 commit intokeystonejs:masterfrom
neagle wants to merge 1 commit intokeystonejs:masterfrom
Conversation
I had to make the same fixes that I later saw suggested by @ivanclaud to get this working locally.
Contributor
|
I'm closing this in favour of #19, however thanks so much for highlighting this issue. |
|
Yes, please merge? Happy to help maintain if that helps. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had to make the same fixes that I later saw suggested by @ivanclaud to
get this working locally.
Related to: #14