Skip to content
This repository was archived by the owner on Nov 24, 2021. It is now read-only.

Fix using nodemailer#27

Open
Noviny wants to merge 4 commits intomasterfrom
fix-using-nodemailer
Open

Fix using nodemailer#27
Noviny wants to merge 4 commits intomasterfrom
fix-using-nodemailer

Conversation

@Noviny
Copy link
Contributor

@Noviny Noviny commented Mar 20, 2017

NB: This is a branch off #19. I've unified it so there is only one processAddress function. This has meant a bit of variance from either one individually:

  • An address is always returned, meaning all return object are at minimum { email, address }
  • If name and email is provided, address string is always a union name address
  • Removed nodemailer-specific email regex (we are shying away from confirming emails are emails)

These changes break three of the nodemailer tests. Want to make sure this is fine before fixing those tests to pass.

@quaz579
Copy link

quaz579 commented Oct 23, 2017

Is there any more information on this? We'd like to use nodemailer in our project and this fix is necessary to enable it.

@mrfrase3 mrfrase3 mentioned this pull request Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants