Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b23b849:
|
Honestly, I think this is a good approach. We do this already, and it's solid. The primary downside I can see is the lack of human readability for the binary file on GitHub. We otherwise have the |
|
Maybe we can build the |
The intention was to still have the needed |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
|
@dcousens - I think I've found a reasonable solution, have updated the PR. |
a83084f to
c05447b
Compare
Using
examples/usecase-todoto change the examples approach to solve for codesandbox issues.seed-datacommandpostinstallto avoid possible conflicts with prisma minor patch changes to their generatorTo solve for the examples snapshot tests:
test:monorepo-snapshot-testcommand to replacepostinstalltest:examples-snapshot-teststo root package.json which targets the above command recursively in all examples foldersexamples_snapshot_teststest to ci to run the above command onceThis is going to significantly reduce the time for actions as each of the smoke tests currently runs the postinstall for all the examples each time (~5m).
This approach also allows us to handle
framework-nextjs-two-serversas well.