Remove inferenceExtension Helm values and enable inference implicitly with agentgateway#13373
Open
Aaravanand00 wants to merge 1 commit intokgateway-dev:mainfrom
Open
Conversation
gateway-bot
added
do-not-merge/description-invalid
do-not-merge/kind-invalid
…nabled - Remove inferenceExtension section from kgateway and agentgateway values.yaml - Remove conditional logic from deployment templates - always enable inference - Remove conditional logic from RBAC templates - always grant inference permissions - Update test manifests to remove inferenceExtension references - Update CI workflows to remove inferenceExtension flags - Update documentation to reflect simplified configuration Fixes kgateway-dev#12905 Signed-off-by: Aaravanand00 <aaravanand5749@gmail.com>
Aaravanand00
force-pushed
the
cleanup/remove-inference-helm-values
branch
from
e741fa3 to
5eb5916
Compare
npolshakova
requested changes
Feb 2, 2026
Contributor
npolshakova
left a comment
npolshakova
left a comment
There was a problem hiding this comment.
Missing some spots that needs to be updated:
- https://github.com/kgateway-dev/kgateway/blob/main/pkg/agentgateway/plugins/collection.go#L163
kgateway/pkg/deployer/values.go
Line 22 in da4c3eb
Also:
- Please make sure to follow the PR description template
- Test the changes locally before submitting your PR.
Contributor
|
@Aaravanand00 do you still plan to work on this issue? |
Author
Yes sir, actually my college tests and viva was going on that's why I'm not active regularly in 1-2 days I become regularly and do active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses Issue #12905 by removing the explicit
inferenceExtensionHelm valuesand simplifying inference enablement behavior.
What changed
inferenceExtensionfrom Helmvalues.yamlfor both kgateway and agentgatewayagentgatewayis enabledWhy
Guarantees
Fixes #12905