Skip to content

Feat/add kubernetes labels #13439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TRIVENI206 wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Feat/add kubernetes labels #13439

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fd61f29
feat: add kubernetes component labels to controller and gateway
TRIVENI206 Jan 28, 2026
095bff1
feat: clean centralization of kubernetes component labels
TRIVENI206 Jan 28, 2026
9d1efb8
refine componentlabel values for controller and gateway
TRIVENI206 Jan 30, 2026
5804c28
test: refresh deployer golden outputs for component labels
Feb 3, 2026
da2ab17
Merge branch 'main' into feat/add-kubernetes-labels
TRIVENI206 Feb 3, 2026
9eaa11a
test: refresh helm golden outputs after component labels update
Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions install/helm/agentgateway/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ Selector labels
agentgateway: agentgateway
app.kubernetes.io/name: {{ include "agentgateway.name" . }}
app.kubernetes.io/instance: {{ .Release.Name }}
app.kubernetes.io/component: controller
Copy link
Contributor

@npolshakova npolshakova Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add the type to the controller here and in install/helm/kgateway/templates/_helpers.tpl:

Suggested change
app.kubernetes.io/component: controller
app.kubernetes.io/component: agentgateway-controller

{{- end }}

{{/*
Expand Down
1 change: 1 addition & 0 deletions install/helm/kgateway/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ Selector labels
kgateway: kgateway
app.kubernetes.io/name: {{ include "kgateway.name" . }}
app.kubernetes.io/instance: {{ .Release.Name }}
app.kubernetes.io/component: controller
{{- end }}

{{/*
Expand Down
1 change: 1 addition & 0 deletions pkg/kgateway/helm/agentgateway/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ Selector labels
{{- define "kgateway.gateway.selectorLabels" -}}
app.kubernetes.io/name: {{ include "kgateway.gateway.name" . }}
app.kubernetes.io/instance: {{ include "kgateway.gateway.fullname" . }}
app.kubernetes.io/component: gateway
gateway.networking.k8s.io/gateway-name: {{ include "kgateway.gateway.fullname" . }}
{{- end }}

Expand Down
1 change: 1 addition & 0 deletions pkg/kgateway/helm/envoy/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ Selector labels
{{- define "kgateway.gateway.selectorLabels" -}}
app.kubernetes.io/name: {{ include "kgateway.gateway.name" . }}
app.kubernetes.io/instance: {{ include "kgateway.gateway.name" . }}
app.kubernetes.io/component: gateway
gateway.networking.k8s.io/gateway-name: {{ include "kgateway.gateway.name" . }}
{{- end }}

Expand Down
Loading