MBL-2793: Search integrated within HomeActivity as navigation destination#2466
MBL-2793: Search integrated within HomeActivity as navigation destination#2466
Conversation
…chAndFilterActivity
…ng them dynamic - Hoisted navigation Logic into parent composable, FloatingBottomNav only dependency is list<Tabs>
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2466 +/- ##
============================================
- Coverage 64.75% 64.70% -0.06%
- Complexity 2416 2420 +4
============================================
Files 382 382
Lines 28938 29017 +79
Branches 4176 4197 +21
============================================
+ Hits 18740 18775 +35
- Misses 7924 7975 +51
+ Partials 2274 2267 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| when (tab) { | ||
| is Tab.Search -> { | ||
| composable(tab.route) { | ||
| SearchAndFilterScreen( |
There was a problem hiding this comment.
Integrating the newly created SearchAndFilterScreen as navigation destination by utilizing the same Composable and ViewModel pair currently used in SearchAndFilterActivity, we are ensuring feature parity while initiating our transition away from Activity-based navigation. This represents the first step in our long-term strategy to adopt a modern, Compose-driven navigation architecture.
There was a problem hiding this comment.
Nice idea to make these reusable 🙏
| } | ||
|
|
||
| @Composable | ||
| private fun setUpErrorActions(snackbarHostState: SnackbarHostState): (String?) -> Job { |
There was a problem hiding this comment.
Couple of small things here:
- Can we include the TODO from L161 of SearchAndFilterActivity about the stacking snackbars in case we ever get a chance to update it 😄
- Perhaps a nit: A return type of
Jobis very particular, and in this case since we won't be acting on the Job, just invoking the lambda, it may be clearer if we exclude it. We could explicitly define the return type for the lambda,errorAction: (String?) -> Unit = ..., and then the same for the whole functionsetUpErrorActions().
📲 What
SearchAndFilterto hold a parent composableThis parent composable is able to be loaded in HomeScreen as navigation destination as the same time as keeping it on
SearchAndFilteractivity.🤔 Why
🛠 How
👀 See
Screen_recording_20260121_165530.mp4
| | |
📋 QA
Story 📖
MBL-2793