ScrollViewer Rework #568
Draft
ScrollViewer Rework #568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert ScrollViewer and ScrollBar to ContolTheme instead of style.
The AllowAutoHide=False is broken in Suki and have no expanded bars, that's why this PR as I need the feature.
The ScrollBar and probably ScrollViewer require atention @kikipoulet, I didn't fully cover the styling, too much to change in ScrollBar and it look like we need 3 styles to make same effect as fluent theme.
Maybe instead of using suki keys we keep ScrollBar as it is and make use of native keys? eg:
ScrollBarButtonBackground,ScrollBarButtonBorderBrush,ScrollBarTrackFill, etc?Also .Stack class need implementation.
So far I have:
This PR also adds
MenuScrollViewer, big menu was not getting any scroll.I will need help with this PR.