Skip to content
This repository was archived by the owner on Jun 25, 2024. It is now read-only.

Support handlebars >=2 <=4#5

Open
AubreyHewes wants to merge 4 commits intokingsquare:masterfrom
AubreyHewes:pr/hbs4
Open

Support handlebars >=2 <=4#5
AubreyHewes wants to merge 4 commits intokingsquare:masterfrom
AubreyHewes:pr/hbs4

Conversation

@AubreyHewes
Copy link
Member

@AubreyHewes AubreyHewes commented Dec 11, 2018 •
edited
Loading

This is currently WIP. Added as PR for feedback/discussion.

It is backwards compatible for hbs v2
hbs v3 and v4 are the WIP

Tests are at
35 passing (5s)
3 failing

#getPaths()
    1) should get stuff from helper methods too

#invoiceTotals rounds correctly
    2) will give various totals

#getTemplateData() - Languages
    3) should work

@AubreyHewes AubreyHewes self-assigned this Dec 11, 2018
@AubreyHewes AubreyHewes added enhancement wip Work in Progress labels Dec 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Reggino Reggino Awaiting requested review from Reggino

@fruitl00p fruitl00p Awaiting requested review from fruitl00p

@mishavantol mishavantol Awaiting requested review from mishavantol

Assignees

@AubreyHewes AubreyHewes

Labels

enhancement wip Work in Progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@AubreyHewes