generateRandomBytes is faulty#325
Merged
vincent-richard merged 2 commits intokisli:masterfrom Jul 21, 2025
Merged
Conversation
Contributor
jengelh
commented
Jul 8, 2025
jengelh
commented
- not checking read() result leads to undefined bytes in the output; fill them up with the fallback loop
- fallback loop erroneously uses %255; this produces a non-uniform distribution of the result
posixHandler.cpp: In member function 'virtual void vmime::platforms::posix::posixHandler::generateRandomBytes(unsigned char*, unsigned int)': posixHandler.cpp:281:21: warning: ignoring return value of 'ssize_t read(int, void*, size_t)' declared with attribute 'warn_unused_result' [-Wunused-result] 281 | read(fd, buffer, count);
x % 255 produces values in the range [0..254], which is wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.