Add support for Python 3.10-3.13 with updated dependencies#122
Merged
kiudee merged 3 commits intokiudee:masterfrom Oct 26, 2025
Merged
Add support for Python 3.10-3.13 with updated dependencies#122kiudee merged 3 commits intokiudee:masterfrom
kiudee merged 3 commits intokiudee:masterfrom
Conversation
All Python 3.10.x versions on GitHub Actions macOS runners have a broken gettext dependency. Since we test Python 3.10 on both Ubuntu and Windows, skipping macOS 3.10 provides adequate coverage. Issue: https://github.com/actions/setup-python/issues/577 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the project to support Python 3.10 through 3.13, updating dependencies to their latest compatible versions and fixing code quality issues identified by updated linters.
Key changes:
- Upgraded minimum Python version from 3.8-3.9 to 3.10-3.13
- Updated core dependencies (numpy 2.0.0+, arviz 0.18.0+, scikit-learn 1.6+, matplotlib 3.9.0+, scipy 1.13.0+)
- Fixed flake8 errors: lambda variable binding (B023) and unsafe zip operations (B905)
Reviewed Changes
Copilot reviewed 11 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Updated Python version constraint and all dependency minimum versions |
| noxfile.py | Updated test matrix to Python 3.10-3.13 and added missing setuptools/wheel installations |
| .github/workflows/tests.yml | Expanded CI matrix to test Python 3.10-3.13 across Ubuntu, macOS, and Windows |
| .github/workflows/release.yml | Updated release workflow to Python 3.13 |
| bask/utils.py | Migrated from deprecated collections.Sequence to collections.abc.Sequence |
| bask/acquisition.py | Fixed lambda variable binding issue in list comprehension |
| bask/bayesgpr.py | Added strict=True to zip() calls for safer iteration |
| bask/searchcv.py | Added score_name parameter to _step method signature |
| tests/test_utils.py | Added strict=True to zip() call |
| tests/test_optimizer.py | Increased n_random_starts and updated expected values for better convergence |
| bask/init.py | Added blank line for formatting consistency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+318
to
+320
| def _step( | ||
| self, search_space, optimizer, score_name, evaluate_candidates, n_points=1 | ||
| ): |
There was a problem hiding this comment.
The score_name parameter is added to the method signature but is never used in the function body. It's only returned unchanged. If this parameter serves no purpose other than pass-through, consider documenting why it's needed or removing it if it's unused by callers.
AlexisOlson
added a commit
to AlexisOlson/chess-tuning-tools
that referenced
this pull request
Oct 26, 2025
Switch from git fork dependency to released version now that kiudee/bayes-skopt#122 has been merged and bask 0.11.0 is published. All 27 tests pass with the released version. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for Python 3.10, 3.11, 3.12, and 3.13, updating dependencies to be compatible with the latest Python versions.
Changes
Dependency Updates:
>=1.26.0to>=2.0.0for Python 3.13 compatibilitydataextra in pyproject.toml (required by noxfile)Code Quality:
strict=Trueto allzip()calls for safer iterationCI Updates:
Testing
All tests pass on:
Breaking Changes
Notes
Python 3.10 testing on macOS was skipped due to a persistent gettext library issue in GitHub Actions runners (see actions/setup-python#577). Python 3.10 is still thoroughly tested on both Ubuntu and Windows platforms.