Skip to content
This repository was archived by the owner on Jan 21, 2025. It is now read-only.

Develop surv estimating functions#1

Open
AndreasNordland wants to merge 55 commits intodevelopfrom
develop_surv_estimating_functions
Open

Develop surv estimating functions#1
AndreasNordland wants to merge 55 commits intodevelopfrom
develop_surv_estimating_functions

Conversation

@AndreasNordland
Copy link
Collaborator

cumhaz: survfit objects, coxph.null objects

  • see test-cumhaz.R

surv_estimating_functions.R:

  • rcai (right censoring augmentation integral)
  • see test-surv_estimating_functions.R, test-rcai.R

H_constructor.R:

  • risk, surv, rmst
  • see test-H_constructor

int_surv.R

  • see test-int_surv.R

@AndreasNordland AndreasNordland requested a review from kkholst June 26, 2024 11:42
@benesom
Copy link
Collaborator

benesom commented Nov 28, 2024

The documentation for rcai is incomplete and should perhaps be correct before merging this PR
image
image

…t/target into feature/replace-testthat-on-develop_surv_estimating_functions
…inytest::test_package`

This change ensures that unit testing for R behaves identical when using `make r_test` and `make r_check`. This has not been the case before since `devtools::load_all` allows testing package internal functions without using `:::`. However, testing package internal functions with `make r_check` will fail if `:::` is not used. Installing the package before running the unit tests ensures that edited package functions and tests files are tested. In addition, a draft of contributing guidelines are added.
…-testthat-on-develop_surv_estimating_functions
@benesom
Copy link
Collaborator

benesom commented Jan 3, 2025

Before merging this PR, we should first merge #7 into this branch. Then update this branch with the most recent changes on develop.

benesom and others added 2 commits January 3, 2025 12:44
…p_surv_estimating_functions

refactoring tests to use tinytest instead of testthat
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants