integrationsource/integrationsink AWS e2e tests#8849
Merged
knative-prow[bot] merged 21 commits intoknative:mainfrom Feb 5, 2026
Merged
integrationsource/integrationsink AWS e2e tests#8849knative-prow[bot] merged 21 commits intoknative:mainfrom
knative-prow[bot] merged 21 commits intoknative:mainfrom
Conversation
knative-prow
bot
added
the
area/test-and-release
|
There are empty aliases in OWNER_ALIASES, cleanup is advised. |
knative-prow
bot
added
the
size/XXL
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8849 +/- ##
==========================================
- Coverage 50.64% 50.63% -0.01%
==========================================
Files 409 409
Lines 21658 21658
==========================================
- Hits 10968 10966 -2
- Misses 9834 9835 +1
- Partials 856 857 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
simkam
force-pushed
the
eventing-integrations-e2e
branch
2 times, most recently
from
64c72fd to
2ab06a5
Compare
knative-prow
bot
added
the
do-not-merge/work-in-progress
simkam
changed the title
simkam
force-pushed
the
eventing-integrations-e2e
branch
2 times, most recently
from
704bc70 to
ce3261f
Compare
knative-prow
bot
removed
the
do-not-merge/work-in-progress
creydr
reviewed
Jan 30, 2026
creydr
reviewed
Jan 30, 2026
| // For SQS sources, sends a message to SQS queue | ||
| // For DynamoDB Streams sources, puts an item to DynamoDB table | ||
| // For Timer sources, does nothing (timer triggers automatically) | ||
| func triggerEventByType(ctx context.Context, t feature.T, sourceType integrationsource.SourceType) { |
Member
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
code moved to reuseable feature steps in resources
creydr
reviewed
Jan 30, 2026
simkam
force-pushed
the
eventing-integrations-e2e
branch
from
ce3261f to
47e4183
Compare
Contributor
Author
|
incorporated feedback and rebased /hold depends on #8867 |
knative-prow
bot
added
the
do-not-merge/hold
…setup and teardown cleanups
simkam
force-pushed
the
eventing-integrations-e2e
branch
from
47e4183 to
576460e
Compare
creydr
reviewed
Feb 5, 2026
| sourceCfg := IntegrationSourceConfigFromContext(ctx) | ||
| secretName := feature.MakeRandomK8sName("aws-credentials") | ||
| awsconfig.InstallAWSSecret(ctx, t, secretName) | ||
| opts := append([]manifest.CfgFn{WithS3Source(sourceCfg.S3Arn, awsCfg.Region, secretName)}, sinkOpts...) |
Contributor
Author
|
rebased |
knative-prow
bot
removed
the
do-not-merge/hold
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, simkam The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
simkam
added a commit
to simkam/eventing
that referenced
this pull request
Feb 5, 2026
* [e2e tests] rename integrationsource_test.go to integrationsource_timer_test.go * [e2e tests] use more descriptive source name and sink name variables * [e2e tests] parametrize IntegrationSource type * [e2e tests] fix typos in IntegrationSource tests * [e2e-tests] add test for AWS S3 IntegrationSource * [e2e-tests] add test for AWS SQS IntegrationSource * [e2e-tests] add test for DynamoDB Stream IntegrationSource * [e2e-tests] integrationsource: move "trigger event" to Assert phase * [e2e tests] parametrize IntegrationSink type * [e2e-tests] add test for AWS S3 IntegrationSink * [e2e-tests] add test for AWS SQS IntegrationSink * [e2e-tests] add test for AWS SNS IntegrationSink * [e2e-tests] use long polling to eliminate empty receiveMessage calls for SQS * [e2e-tests] move AWS related code to single place * [e2e-tests] run AWS tests only with e2e_aws tag * [e2e-tests] update README for e2e rekt tests * [e2e-tests] use UUID as primary key for DynamoDB table * [e2e-tests] workaround delayed readiness of ddbstreams source * update-codegen * [e2e-tests] remove workaround for SRVKE-1834 fixed in knative#8867 * [e2e-tests] move sink/source code to reusable Feature Steps, improve setup and teardown cleanups
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first ever Golang contribution (obviously also the first using reconciler-test framework), so I would appreciate a thorough review and some patience.
This adds a new tag for e2e tests called
e2e_awsthat runs tests for integrationsink/integrationsource resources that use AWS services. See updatedtest/rekt/README.mdfor all details.New tests (tag) pass locally and we will run them in an internal Jenkins. We can also consider including them in GH CI.
Usual note nowadays - written with help from AI - Google Gemini and Claude Code.