Xyseries to generic1#314
Open
rgwood-github2018dec31 wants to merge 3 commits intoknowm:developfrom
rgwood-github2018dec31:xyseries_to_generic1
Open
Xyseries to generic1#314rgwood-github2018dec31 wants to merge 3 commits intoknowm:developfrom rgwood-github2018dec31:xyseries_to_generic1
rgwood-github2018dec31 wants to merge 3 commits intoknowm:developfrom
rgwood-github2018dec31:xyseries_to_generic1
Conversation
Member
|
I'm having a hard time understanding what this is doing better since I'm short on time to dedicate brain cells to it. Can you give me a quick summary? |
Author
|
No problem. The existing code requires one to create arrays to draw a chart. Often one already has say a List_T and so the array creation is not required. Also Let's sat T is: class StockPrice { double price; double vol; Date dateTime} Now one just needs to provide a few functions to turn each StockPrice into x and y to draw a graph. Other than the first comment overview, what more did you wan to to know? |
Contributor
|
What is the performance impact of this change from double[] arrays to Lists? |
Author
|
Hi Tomas.
One issue with double[] is that you have to create it beforehand. For
example, if one has:
List<Foo> list= ...
and:
class Foo { double x, double y; }
You have to:
double[] arr=new double[list.size()];
// populate arr
// chart
But why? We already have the x and y values. We could allow anything that
impls List<?> to be charted w/o creating a double[] or pre-populating it.
For example, if I have a CSV, or table in a db, as long as I impl some list
adapter I can chart it if the chart interface takes a List<?>
…--
R Garth Wood
E: garth.wood@gmail.com <garth.wood@fullrank.com>, M: 416 930 2772
On Wed, 18 Sep 2019 at 03:40, Tomas Svensson ***@***.***> wrote:
What is the performance impact of this change from double[] arrays to
Lists?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#314?email_source=notifications&email_token=ALBFNFUL62SHLFVKWBNSL6TQKHLO5A5CNFSM4HK5B6MKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD67D6DY#issuecomment-532561679>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALBFNFSYIYL4KJGA3HXJONTQKHLO5ANCNFSM4HK5B6MA>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview: I changed XYseries to accept a list and functions as opposed to forcing clients to create multiple arrays on each create/update.
This is the beginning but I've run out of time tonight. The double[] constuctors still work but, wonce you move to jdk8 you can do something like:
class Foo { double x; double y; double bubbleSz; }
List list= ...
XYSeries ser=new XYSeries("s1", list, axisType
, (list, rowi, obj) -> { return ((Foo)obj).x; }
, (list, rowi, obj) -> { return ((Foo)obj).y; }
, (list, rowi, obj) -> { return ((Foo)obj).bubbleSz; }
);
Had to comment out some code as some libs didn't import into eclipse properly. Hope you can find the time to integrate this and update to jdk8. CHeers!