Give the possibility to supply a custom label generator for pie charts#847
Open
ggiambo wants to merge 2 commits intoknowm:developfrom
Open
Give the possibility to supply a custom label generator for pie charts#847ggiambo wants to merge 2 commits intoknowm:developfrom
ggiambo wants to merge 2 commits intoknowm:developfrom
Conversation
mccartney
approved these changes
Jun 5, 2024
Collaborator
mccartney
left a comment
There was a problem hiding this comment.
Looks good to me. This seems reasonable feature to add.
Thanks for the contribution.
Member
|
Thanks for putting in the effort to change the implementation from your previous PR. Can you change the demo to be in the same format at in , without needing to define |
Contributor
Author
|
Hi @timmolter |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #698.
Demo of
PieChart02with labels showing percentage:Before

After
