Added function Arr::extract_existing()#369
Open
danieliser wants to merge 1 commit intokohana:3.4/developfrom
danieliser:patch-2
Open
Added function Arr::extract_existing()#369danieliser wants to merge 1 commit intokohana:3.4/developfrom danieliser:patch-2
danieliser wants to merge 1 commit intokohana:3.4/developfrom
danieliser:patch-2
Conversation
Similar to extract except that it doesnt return keys that arnt set in the first array.
EX..
Arr::filter(
array('a' => 'foo', 'b' => 'bar'),
array('a','c')
);
Returns array('a' => 'foo')
Key b is removed from results altogether.
This is particularly useful for extracting fields from $_POST for Model without leaveing unset values as NULL.
Regular extract in this situation will end up saving value "C" above as NULL even if your only attempting to change "A".
Member
|
Did you ever make a redmine ticket for this? |
Contributor
|
Bit of a mouthful, Underscore calls this pick. You could rewrite the method to: array_intersect_key($arr, array_flip($keys))But this won't work on objects that implement |
Contributor
|
Thanks for this @danieliser. No need for a Redmine ticket anymore, but definitely unit tests :) |
Contributor
|
Also, I think the method name needs to change, but I am not sure. |
Member
Author
|
Agreed, i thought of several names since. Glad to see this finally make it into core. Hell glad to see that project isn't dead. Felt like community died shortly after i started using Kohana heavily. |
Member
|
I like this, missing tests, should be for 4.0.0? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to extract except that it doesnt return keys that arnt set in the first array.
EX..
Arr::filter(
array('a' => 'foo', 'b' => 'bar'),
array('a','c')
);
Returns array('a' => 'foo')
Key b is removed from results altogether.
This is particularly useful for extracting fields from $_POST for Model without leaveing unset values as NULL.
Regular extract in this situation will end up saving value "C" above as NULL even if your only attempting to change "A".