Added convenience methods for request type checking#417
Open
marklocker wants to merge 2 commits intokohana:3.4/developfrom
marklocker:3.4/feature/4606-is-type-methods
Open
Added convenience methods for request type checking#417marklocker wants to merge 2 commits intokohana:3.4/developfrom marklocker:3.4/feature/4606-is-type-methods
marklocker wants to merge 2 commits intokohana:3.4/developfrom
marklocker:3.4/feature/4606-is-type-methods
Conversation
Convenience methods for the four most common request types.
classes/Kohana/Request.php
Outdated
Contributor
There was a problem hiding this comment.
return ($this->method() === HTTP_Request::POST)
There was a problem hiding this comment.
return ($this->_method === HTTP_Request::POST)
Contributor
There was a problem hiding this comment.
@birkir yep, you're right, but canonical
return (HTTP_Request::POST === $this->_method)
Contributor
There was a problem hiding this comment.
Are the parentheses needed here?
Edit: Nevermind, I see that this is the style follow through the rest of the file.
Author
|
Quite right - a little too concerned with adhering to Kohana's "braces on new lines" guideline I think! |
Member
|
There seem to be merge conflicts here, could you merge the latest |
Member
|
I like this for 4.0.0 but needs to be done manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added convenience methods for the four most common request types.
Related issue: http://dev.kohanaframework.org/issues/4606