add file driver config can be save like the database#566
Open
ljyf5593 wants to merge 1 commit intokohana:3.3/developfrom
Open
add file driver config can be save like the database#566ljyf5593 wants to merge 1 commit intokohana:3.3/developfrom
ljyf5593 wants to merge 1 commit intokohana:3.3/developfrom
Conversation
Contributor
There was a problem hiding this comment.
this should probably check for is_writable first.
Contributor
There was a problem hiding this comment.
@ljyf5593 very sorry to come back to you this late. Could you kindly note @shadowhand 's comment here, as I think the sooner we check for is_writable the better. And maybe should we add a try... catch block here for the same reasons?
Thanks.
Contributor
|
I think this should be updated to use the same pattern as kohana/database#77 |
Contributor
|
This needs unittesting too. Thank you for your time. |
Member
|
needs to be reviewed tested and considered for 4.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add file driver config can be save like the database