Add support for rendering with block instead of partial#163
Open
jonmast wants to merge 1 commit intokomposable:masterfrom
Open
Add support for rendering with block instead of partial#163jonmast wants to merge 1 commit intokomposable:masterfrom
jonmast wants to merge 1 commit intokomposable:masterfrom
Conversation
Add a `render` macro to the ComponentHelper, which takes a block that is used to render the component instead of using the partial. This is mainly useful for small components that will be rendered many times, the overhead of rendering the partial can be quite significant.
jonmast
force-pushed
the
components-without-partials
branch
from
1cc3d49 to
d785e5f
Compare
Spone
approved these changes
Oct 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #138
Add a
rendermacro to the ComponentHelper, which takes a block that is used to render the component instead of using the partial. This is mainly useful for small components that will be rendered many times where the overhead of rendering the partial can be quite significant.The issue hinted at using a
rendermethod for this, I chose not to go that route because it would override the built in method which seems problematic. Using a custom DSL for this makes it more explicit but has the downside of dealing with the various quirks of blocks as opposed to methods. Another option would be to use a differently named method (render_component?), but that has the downside of people accidentally using the name for a regular helper method. I'm open to any suggestion on a better API for it.