feat(metrics): add IndexedFamily and LabelIndexMapping derive #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Which issue does this PR close? Closes #. # Rationale for this change The existing dynamic `Family` implementation is flexible but incurs hash lookup overhead on hot update paths. For fixed-cardinality label domains, we need a faster indexed path while keeping encoding behavior and API ergonomics consistent. # What changes are included in this PR? - Added `metrics::family::IndexedFamily` for fixed-cardinality indexed storage. - Added `metrics::family::LabelIndexMapping` trait and `LabelIndex` token for reusable indexed lookups. - Split family module into `dynamic` and `indexed`, and re-exported public types from `metrics::family`. - Added `#[derive(LabelIndexMapping)]` in `fastmetrics-derive` for unit enums and named structs. - Added trybuild coverage for `LabelIndexMapping` pass/fail cases and updated related UI tests. - Updated family benchmarks to include `fastmetrics_indexed` cases. - Synced latest `just bench family` results into `benchmarks/README.md`. # Are there any user-facing changes? Yes. - New public APIs: `IndexedFamily`, `LabelIndex`, and `LabelIndexMapping`. - New derive macro: `fastmetrics_derive::LabelIndexMapping`. - Benchmark documentation updated with new family benchmark numbers. # AI usage statement This change was implemented with assistance from OpenAI Codex using model `gpt-5.3-codex` with reasoning effort `xhigh`, and reviewed/edited before commit.
dosubot
bot
added
size:XL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
The existing dynamic
Familyimplementation is flexible but incurs hash lookup overhead on hot update paths. For fixed-cardinality label domains, we need a faster indexed path while keeping encoding behavior and API ergonomics consistent.What changes are included in this PR?
metrics::family::IndexedFamilyfor fixed-cardinality indexed storage.metrics::family::LabelIndexMappingtrait andLabelIndextoken for reusable indexed lookups.dynamicandindexed, and re-exported public types frommetrics::family.#[derive(LabelIndexMapping)]infastmetrics-derivefor unit enums and named structs.LabelIndexMappingpass/fail cases and updated related UI tests.fastmetrics_indexedcases.just bench familyresults intobenchmarks/README.md.Are there any user-facing changes?
Yes.
IndexedFamily,LabelIndex, andLabelIndexMapping.fastmetrics_derive::LabelIndexMapping.AI usage statement
This change was implemented with assistance from OpenAI Codex using model
gpt-5.3-codexwith reasoning effortxhigh, and reviewed/edited before commit.