-
-
Notifications
You must be signed in to change notification settings - Fork 427
Add performance e2e tests with large schema fixtures #2782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThis pull request upgrades the GitHub Actions Python setup action from v4 to v6, introduces a pytest marker filter to exclude performance tests from CI benchmarks, and adds a corresponding Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (59)
tests/data/performance/aws_style.yamlis excluded by!tests/data/**/*.yamland included by nonetests/data/performance/complex_refs.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/deep_nested.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/duplicate_names.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/graphql_style.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/kubernetes_style.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/large_models.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/multiple_files/module_00.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/multiple_files/module_01.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/multiple_files/module_02.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/multiple_files/module_03.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/multiple_files/module_04.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/multiple_files/module_05.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/multiple_files/module_06.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/multiple_files/module_07.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/multiple_files/module_08.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/multiple_files/module_09.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/multiple_files/module_10.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/multiple_files/module_11.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/multiple_files/module_12.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/multiple_files/module_13.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/multiple_files/module_14.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/multiple_files/module_15.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/multiple_files/module_16.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/multiple_files/module_17.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/multiple_files/module_18.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/multiple_files/module_19.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/multiple_files/module_20.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/multiple_files/module_21.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/multiple_files/module_22.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/multiple_files/module_23.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/multiple_files/module_24.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/multiple_files/module_25.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/multiple_files/module_26.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/multiple_files/module_27.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/multiple_files/module_28.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/multiple_files/module_29.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/multiple_files/module_30.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/multiple_files/module_31.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/multiple_files/module_32.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/multiple_files/module_33.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/multiple_files/module_34.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/multiple_files/module_35.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/multiple_files/module_36.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/multiple_files/module_37.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/multiple_files/module_38.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/multiple_files/module_39.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/multiple_files/module_40.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/multiple_files/module_41.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/multiple_files/module_42.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/multiple_files/module_43.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/multiple_files/module_44.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/multiple_files/module_45.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/multiple_files/module_46.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/multiple_files/module_47.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/multiple_files/module_48.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/multiple_files/module_49.jsonis excluded by!tests/data/**/*.jsonand included by nonetests/data/performance/openapi_large.yamlis excluded by!tests/data/**/*.yamland included by nonetests/data/performance/stripe_style.jsonis excluded by!tests/data/**/*.jsonand included by none
📒 Files selected for processing (3)
.github/workflows/perf.yamltests/main/test_performance.pytox.ini
🧰 Additional context used
🪛 actionlint (1.7.9)
.github/workflows/perf.yaml
23-23: the runner of "actions/setup-python@v4" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)
- GitHub Check: Analyze (python)
- GitHub Check: py312-isort6 on Ubuntu
- GitHub Check: 3.12 on Ubuntu
- GitHub Check: py312-black22 on Ubuntu
- GitHub Check: py312-pydantic1 on Ubuntu
- GitHub Check: 3.13 on Ubuntu
- GitHub Check: 3.12 on macOS
- GitHub Check: 3.11 on Ubuntu
- GitHub Check: 3.10 on Ubuntu
- GitHub Check: 3.13 on Windows
- GitHub Check: py312-isort5 on Ubuntu
- GitHub Check: py312-isort7 on Ubuntu
- GitHub Check: py312-black24 on Ubuntu
- GitHub Check: 3.14 on Ubuntu
- GitHub Check: 3.10 on macOS
- GitHub Check: 3.14 on macOS
- GitHub Check: py312-black23 on Ubuntu
- GitHub Check: 3.11 on macOS
- GitHub Check: benchmarks
- GitHub Check: benchmarks
🔇 Additional comments (6)
.github/workflows/perf.yaml (6)
1-10: LGTM: Workflow triggers are well-configured.The workflow name and trigger configuration are appropriate for performance benchmarking. Including
workflow_dispatchis particularly useful for CodSpeed's backtest feature.
12-14: LGTM: Good concurrency control.The concurrency configuration prevents redundant benchmark runs on the same branch with automatic cancellation of in-progress runs.
21-22: LGTM: Helpful documentation.The comment explaining the uv standalone build incompatibility with CodSpeedHQ and linking to the relevant issue is valuable documentation for future maintainers.
26-29: LGTM: Dependency installation is correct.The use of
astral-sh/setup-uv@v5anduv sync --all-extrasproperly installs all dependencies needed for the performance tests.
30-35: pytest-xdist is already included in the project dependencies (pyproject.toml specifiespytest-xdist>=3.3.1). No action required.Likely an incorrect or invalid review comment.
18-18: > Likely an incorrect or invalid review comment.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2782 +/- ##
========================================
Coverage 99.48% 99.49%
========================================
Files 87 88 +1
Lines 13016 13212 +196
Branches 1555 1556 +1
========================================
+ Hits 12949 13145 +196
Misses 35 35
Partials 32 32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #2782 will not alter performanceComparing Summary
Footnotes
|
a7f1d89 to
6eb7178
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/workflows/codspeed.yamlpyproject.tomltests/main/test_performance.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (19)
- GitHub Check: 3.10 on Windows
- GitHub Check: 3.14 on macOS
- GitHub Check: py312-isort7 on Ubuntu
- GitHub Check: 3.10 on macOS
- GitHub Check: py312-isort6 on Ubuntu
- GitHub Check: py312-black23 on Ubuntu
- GitHub Check: py312-black22 on Ubuntu
- GitHub Check: 3.10 on Ubuntu
- GitHub Check: 3.12 on macOS
- GitHub Check: 3.13 on Ubuntu
- GitHub Check: 3.13 on macOS
- GitHub Check: 3.11 on macOS
- GitHub Check: 3.11 on Windows
- GitHub Check: 3.13 on Windows
- GitHub Check: 3.12 on Windows
- GitHub Check: 3.11 on Ubuntu
- GitHub Check: 3.14 on Windows
- GitHub Check: Analyze (python)
- GitHub Check: benchmarks
🔇 Additional comments (2)
.github/workflows/codspeed.yaml (1)
34-34: Marker filter correctly excludes performance tests from CI benchmarks.The marker expression
"benchmark and not perf"properly filters tests to run benchmark tests while excluding those marked with theperfmarker. This aligns well with the marker definition added in pyproject.toml.pyproject.toml (1)
227-227: Well-defined pytest marker for performance test categorization.The
perfmarker is correctly configured with a clear description. This enables proper test categorization and allows the CI workflow to selectively exclude performance tests from benchmark runs.
Breaking Change AnalysisResult: No breaking changes detected Reasoning: This PR only adds performance tests, test fixtures, and CI/tox configuration. It does not modify any source code that affects code generation, templates, CLI/API, default behavior, Python version support, or error handling. All changes are internal to the testing infrastructure and do not impact users of the library. This analysis was performed by Claude Code Action |
Summary by CodeRabbit
Release Notes
Chores
Tests
✏️ Tip: You can customize this high-level summary in your review settings.