-
Notifications
You must be signed in to change notification settings - Fork 62
Include a Application metrics exposure guide to generate runtime recommendations #1773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: mvp_demo
Are you sure you want to change the base?
Include a Application metrics exposure guide to generate runtime recommendations #1773
Conversation
Signed-off-by: kusuma chalasani <kchalasa@redhat.com>
Reviewer's GuideAdds a new documentation page describing how to expose application metrics for Prometheus so that runtime recommendations can be generated, covering OpenShift user workload monitoring enablement, framework-specific metric exposure (Spring Boot, Quarkus, plain Java with JMX exporter), and Prometheus scrape configuration examples. Sequence diagram for Prometheus scraping application metricssequenceDiagram
participant PROM as prometheus_instance
participant APP as application
participant ME as metrics_endpoint
PROM->>APP: open_http_connection
APP->>ME: route_request_to_metrics_endpoint
ME-->>PROM: respond_with_prometheus_formatted_metrics
PROM->>PROM: store_samples_and_evaluate_rules
PROM-->>APP: close_connection
Flow diagram for configuring application metrics exposure by runtimeflowchart TD
START[start]
RUNTIME["Select application runtime"]
DECIDE_RUNTIME{runtime_type}
SB[spring_boot_configuration]
QK[quarkus_configuration]
PJ[plain_java_jmx_exporter_configuration]
SB_STEPS["Add_actuator_and_micrometer_dependencies_and_enable_prometheus_endpoint"]
QK_STEPS["Add_quarkus_micrometer_prometheus_extension_and_enable_export"]
PJ_STEPS["Run_with_jmx_prometheus_javaagent_and_config_file"]
PROM_CFG["configure_prometheus_scrape_job"]
END[end]
START --> RUNTIME --> DECIDE_RUNTIME
DECIDE_RUNTIME -->|spring_boot| SB
DECIDE_RUNTIME -->|quarkus| QK
DECIDE_RUNTIME -->|plain_java| PJ
SB --> SB_STEPS --> PROM_CFG
QK --> QK_STEPS --> PROM_CFG
PJ --> PJ_STEPS --> PROM_CFG
PROM_CFG --> END
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've left some high level feedback:
- In the OpenShift section, clarify that user application namespaces typically need ServiceMonitor/PodMonitor resources rather than direct Prometheus
scrape_configsnippets, and show how this ties into the example metrics endpoints. - Fix minor wording/formatting issues (e.g.,
Monitoring for user workloads will be enabled automatically.Verifymissing a space, and ensure consistent code block language hints for YAML/XML/Properties where appropriate).
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In the OpenShift section, clarify that user application namespaces typically need ServiceMonitor/PodMonitor resources rather than direct Prometheus `scrape_config` snippets, and show how this ties into the example metrics endpoints.
- Fix minor wording/formatting issues (e.g., `Monitoring for user workloads will be enabled automatically.Verify` missing a space, and ensure consistent code block language hints for YAML/XML/Properties where appropriate).Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Description
Include a Application metrics exposure guide to generate runtime recommendations
Fixes # (issue)
Type of change
Summary by Sourcery
Documentation: