Open
Conversation
grpc.NewClient already supports connecting to unix domain sockets, and accepts a string anyways. As a quick fix, detect the `address` starting with `unix://` and don't add the port. In the long term, we might want to deprecate `host` and `port` cmdline args in favor of a single `address` arg.
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (77.13%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #680 +/- ##
==========================================
+ Coverage 77.10% 77.13% +0.02%
==========================================
Files 57 57
Lines 3910 3915 +5
==========================================
+ Hits 3015 3020 +5
Misses 647 647
Partials 248 248 🚀 New features to boost your workflow:
|
Contributor
Author
|
@ktr0731 poke ;-) |
rsniezek
reviewed
Dec 6, 2023
| addr := cfg.Server.Host | ||
|
|
||
| // as long as the address doesn't start with unix, also add the port. | ||
| if !strings.HasPrefix(cfg.Server.Host, "unix://") { |
There was a problem hiding this comment.
I would personally add --unix switch and use that to decide if we do host:port or just host
Contributor
Author
There was a problem hiding this comment.
I'm waiting on @ktr0731 to decide on the path forward.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
grpc.NewClient already supports connecting to unix domain sockets, and accepts a string anyways.
As a quick fix, detect the
addressstarting withunix://and don't add the port.In the long term, we might want to deprecate
hostandportcmdline args in favor of a singleaddressarg.Fixes #654.