feat(util): add Readiness utility for checking resource readiness status #4539
+956
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a utility class that provides fabric8-style readiness checking for Kubernetes resources. Includes support for: - Pods, Deployments, StatefulSets, ReplicaSets, DaemonSets - Jobs, Nodes, ReplicationControllers - PersistentVolumeClaims, Endpoints, Services The generic isReady() method automatically delegates to the appropriate type-specific method based on the resource type. Also adds comprehensive unit tests covering all readiness checks.
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
yue9944882
reviewed
Jan 23, 2026
| Integer readyReplicas = status.getReadyReplicas(); | ||
|
|
||
| if (replicas == null) { | ||
| replicas = 1; |
Member
There was a problem hiding this comment.
hmm does this defaulting make sense? if it's only for null panic prevention. how about we reverse L246 to:
readyReplicas.equals(replicas);
Contributor
Author
There was a problem hiding this comment.
Changed to return false.
yue9944882
reviewed
Jan 23, 2026
Member
yue9944882
left a comment
yue9944882
left a comment
There was a problem hiding this comment.
one question, otherwise LGTM
brendandburns
added
lgtm
Contributor
Author
|
Comment addressed, please take another look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a utility class that provides fabric8-style readiness checking for Kubernetes resources. Includes support for:
The generic isReady() method automatically delegates to the appropriate type-specific method based on the resource type.
Also adds comprehensive unit tests covering all readiness checks.