WIP: tests: switch wait from polling to watch for more accurate timing #268
+191
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
do-not-merge/work-in-progress
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for agent-sandbox canceled.
|
k8s-ci-robot
added
approved
justinsb
force-pushed
the
use_watch_for_wait
branch
2 times, most recently
from
9ae12e5 to
0238622
Compare
justinsb
commented
Jan 29, 2026
| }), | ||
| } | ||
| require.NoError(t, tc.WaitForObject(t.Context(), sandboxObj, p...)) | ||
| require.NoError(t, tc.PollUntilObject(sandboxObj, p...)) |
Contributor
Author
There was a problem hiding this comment.
Switched because this test seems to fail if we use the (faster) Watch version
justinsb
commented
Jan 29, 2026
|
|
||
| // Wait for the pod to be ready | ||
| require.NoError(testingT, testContext.WaitForObject(testingT.Context(), podObj, predicates.ReadyConditionIsTrue)) | ||
| require.NoError(testingT, testContext.PollUntilObject(podObj, predicates.ReadyConditionIsTrue)) |
Contributor
Author
There was a problem hiding this comment.
This test also fails if we use Watch
k8s-ci-robot
added
the
needs-rebase
justinsb
force-pushed
the
use_watch_for_wait
branch
from
0238622 to
ee65aaa
Compare
k8s-ci-robot
removed
the
needs-rebase
justinsb
force-pushed
the
use_watch_for_wait
branch
2 times, most recently
from
1b3e14c to
02ed71f
Compare
k8s-ci-robot
added
the
needs-rebase
justinsb
force-pushed
the
use_watch_for_wait
branch
from
02ed71f to
5e1839a
Compare
k8s-ci-robot
removed
the
needs-rebase
justinsb
force-pushed
the
use_watch_for_wait
branch
from
5e1839a to
8bb497c
Compare
k8s-ci-robot
added
the
needs-rebase
Contributor
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.