Skip to content

⚠️ Implement v1beta1 ↔ v1beta2 conversion webhooks#2958

Open
bnallapeta wants to merge 1 commit intokubernetes-sigs:mainfrom
bnallapeta:v1beta2-conversion
Open

⚠️ Implement v1beta1 ↔ v1beta2 conversion webhooks#2958
bnallapeta wants to merge 1 commit intokubernetes-sigs:mainfrom
bnallapeta:v1beta2-conversion

Conversation

@bnallapeta
Copy link
Contributor

What this PR does / why we need it:

  • Move Hub markers from v1beta1 to v1beta2, making v1beta2 the conversion hub
  • Implement ConvertTo/ConvertFrom for all resource types (OpenStackCluster, OpenStackMachine, and their Templates/Lists)
  • Add condition format conversion between CAPI v1beta1 conditions and standard metav1.Condition
  • Handle FailureDomains map↔slice conversion and deprecated field derivation

Test plan

  • make test passes (348 tests)
  • make lint passes
  • Unit tests for round-trip conversion of all types
  • Condition conversion tests verify format mapping

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2940 part of #2895

Special notes for your reviewer:

To be merged after #2947

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 19, 2026
@netlify
Copy link

netlify bot commented Jan 19, 2026

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 026a9bd
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-cluster-api-openstack/deploys/6985ef7ad9e875000854844d
😎 Deploy Preview https://deploy-preview-2958--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot requested a review from EmilienM January 19, 2026 06:22
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 19, 2026
@k8s-ci-robot k8s-ci-robot requested a review from lentzi90 January 19, 2026 06:22
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 19, 2026
Signed-off-by: Bharath Nallapeta <nr.bharath97@gmail.com>
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign vincepri for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

Status: Inbox

Development

Successfully merging this pull request may close these issues.

Implement conversion webhooks (v1beta1 ↔ v1beta2)

2 participants