fix: Ensure NodeOverlay matches instance types when using the Exists operator

[andrewhibbert]

Fixes #2765

Description

Fixes an issue where NodeOverlay gets error "label does not have known values" when a NodePool uses the Exists operator and NodeOverlay uses the label and value as a requirement.

How was this change tested?

Unit test written and testing in a kubernetes cluster

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: andrewhibbert
Once this PR has been reviewed and has the lgtm label, please assign gjtempleton for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @andrewhibbert. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[coveralls]

Pull Request Test Coverage Report for Build 21409125207

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 162 of 189 (85.71%) changed or added relevant lines in 3 files are covered.
• 10 unchanged lines in 2 files lost coverage.
• Overall coverage increased (+0.1%) to 80.348%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/cloudprovider/types.go	3	7	42.86%
pkg/controllers/nodeoverlay/store.go	142	165	86.06%

Files with Coverage Reduction	New Missed Lines	%
pkg/controllers/disruption/queue.go	5	81.1%
pkg/controllers/nodeoverlay/store.go	5	86.52%

Totals
Change from base Build 21233813674:	0.1%
Covered Lines:	11832
Relevant Lines:	14726

---

💛 - Coveralls