-
Notifications
You must be signed in to change notification settings - Fork 427
feat: allow configuring MultiNodeConsolidationTimeoutDuration #2831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Ahmed Faizan <faizanofficial120@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: faizan-exe The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @faizan-exe! |
|
Hi @faizan-exe. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Ahmed Faizan <faizanofficial120@gmail.com>
Pull Request Test Coverage Report for Build 21593520831Details
💛 - Coveralls |
|
PTAL. Thanks! |
Fixes #1733 #2826
Description
This PR adds the flag
MultiNodeConsolidationTimeoutin CLI making it configurable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.