-
Notifications
You must be signed in to change notification settings - Fork 1.6k
✨ (helm/v2-alpha): Add Makefile targets for Helm Development #5442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ (helm/v2-alpha): Add Makefile targets for Helm Development #5442
Conversation
8cc1931 to
770a60c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking this up, everything looks fine!
I have seen that you changed the older commands with the makefile targets.
i just got curious and found these, i think most of them could be changed too.
➜ grep -rin 'helm install my-release' *
Binary file bin/kubebuilder matches
docs/book/src/multiversion-tutorial/testdata/project/AGENTS.md:274:# Users install: helm install my-release ./dist/chart/ --namespace <ns> --create-namespace
docs/book/src/plugins/available/helm-v2-alpha.md:336:helm install my-release ./dist/chart \
docs/book/src/getting-started/testdata/project/AGENTS.md:274:# Users install: helm install my-release ./dist/chart/ --namespace <ns> --create-namespace
docs/book/src/cronjob-tutorial/testdata/project/AGENTS.md:274:# Users install: helm install my-release ./dist/chart/ --namespace <ns> --create-namespace
pkg/plugins/golang/v4/scaffolds/internal/templates/agents.go:328:# Users install: helm install my-release ./dist/chart/ --namespace <ns> --create-namespace
pkg/plugins/optional/helm/v1alpha/scaffolds/internal/templates/github/test_chart.go:127: helm install my-release ./dist/chart --create-namespace --namespace {{ .ProjectName }}-system
testdata/project-v4-multigroup/AGENTS.md:274:# Users install: helm install my-release ./dist/chart/ --namespace <ns> --create-namespace
testdata/project-v4/AGENTS.md:274:# Users install: helm install my-release ./dist/chart/ --namespace <ns> --create-namespace
testdata/project-v4-with-plugins/AGENTS.md:274:# Users install: helm install my-release ./dist/chart/ --namespace <ns> --create-namespace
maybe you could run this command to see if there's more to change
➜ grep -rin 'helm install' * | grep -iEv 'cert-manager|prometheus-crds'
770a60c to
42778e3
Compare
|
Done 👍 |
18be9a0 to
09a74f7
Compare
665abdd to
c0fb15a
Compare
c0fb15a to
7aa9aa8
Compare
|
/retest-required |
|
/test pull-kubebuilder-e2e-k8s-1-33-0 |
AlirezaPourchali
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Very informative changes, thanks!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlirezaPourchali, camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override pull-kubebuilder-e2e-k8s-1-33-0 |
|
@camilamacedo86: Overrode contexts on behalf of camilamacedo86: pull-kubebuilder-e2e-k8s-1-33-0 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override pull-kubebuilder-e2e-k8s-1-35-0 |
|
@camilamacedo86: Overrode contexts on behalf of camilamacedo86: pull-kubebuilder-e2e-k8s-1-34-0, pull-kubebuilder-e2e-k8s-1-35-0 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Closes: #5351