Skip to content

Conversation

@camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented Feb 7, 2026

Closes: #5351

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 7, 2026
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 7, 2026
@camilamacedo86 camilamacedo86 force-pushed the helm-makefile-add branch 2 times, most recently from 8cc1931 to 770a60c Compare February 7, 2026 09:19
@camilamacedo86 camilamacedo86 changed the title WIP ✨ (helm/v2-alpha): Add Makefile targets for Helm Development ✨ (helm/v2-alpha): Add Makefile targets for Helm Development Feb 7, 2026
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 7, 2026
Copy link
Contributor

@AlirezaPourchali AlirezaPourchali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up, everything looks fine!
I have seen that you changed the older commands with the makefile targets.
i just got curious and found these, i think most of them could be changed too.

➜  grep -rin 'helm install my-release' *                                           
Binary file bin/kubebuilder matches
docs/book/src/multiversion-tutorial/testdata/project/AGENTS.md:274:# Users install: helm install my-release ./dist/chart/ --namespace <ns> --create-namespace
docs/book/src/plugins/available/helm-v2-alpha.md:336:helm install my-release ./dist/chart \
docs/book/src/getting-started/testdata/project/AGENTS.md:274:# Users install: helm install my-release ./dist/chart/ --namespace <ns> --create-namespace
docs/book/src/cronjob-tutorial/testdata/project/AGENTS.md:274:# Users install: helm install my-release ./dist/chart/ --namespace <ns> --create-namespace
pkg/plugins/golang/v4/scaffolds/internal/templates/agents.go:328:# Users install: helm install my-release ./dist/chart/ --namespace <ns> --create-namespace
pkg/plugins/optional/helm/v1alpha/scaffolds/internal/templates/github/test_chart.go:127:          helm install my-release ./dist/chart --create-namespace --namespace {{ .ProjectName }}-system
testdata/project-v4-multigroup/AGENTS.md:274:# Users install: helm install my-release ./dist/chart/ --namespace <ns> --create-namespace
testdata/project-v4/AGENTS.md:274:# Users install: helm install my-release ./dist/chart/ --namespace <ns> --create-namespace
testdata/project-v4-with-plugins/AGENTS.md:274:# Users install: helm install my-release ./dist/chart/ --namespace <ns> --create-namespace

maybe you could run this command to see if there's more to change

➜  grep -rin 'helm install' * | grep -iEv 'cert-manager|prometheus-crds'

@camilamacedo86
Copy link
Member Author

Hi @AlirezaPourchali

Done 👍

@camilamacedo86 camilamacedo86 force-pushed the helm-makefile-add branch 2 times, most recently from 18be9a0 to 09a74f7 Compare February 8, 2026 08:23
@camilamacedo86 camilamacedo86 force-pushed the helm-makefile-add branch 4 times, most recently from 665abdd to c0fb15a Compare February 8, 2026 11:24
@camilamacedo86
Copy link
Member Author

/retest-required

@camilamacedo86
Copy link
Member Author

/test pull-kubebuilder-e2e-k8s-1-33-0

Copy link
Contributor

@AlirezaPourchali AlirezaPourchali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Very informative changes, thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlirezaPourchali, camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@camilamacedo86
Copy link
Member Author

/override pull-kubebuilder-e2e-k8s-1-33-0

@k8s-ci-robot
Copy link
Contributor

@camilamacedo86: Overrode contexts on behalf of camilamacedo86: pull-kubebuilder-e2e-k8s-1-33-0

Details

In response to this:

/override pull-kubebuilder-e2e-k8s-1-33-0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@camilamacedo86 camilamacedo86 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2026
@camilamacedo86
Copy link
Member Author

/override pull-kubebuilder-e2e-k8s-1-35-0
/override pull-kubebuilder-e2e-k8s-1-34-0

@k8s-ci-robot
Copy link
Contributor

@camilamacedo86: Overrode contexts on behalf of camilamacedo86: pull-kubebuilder-e2e-k8s-1-34-0, pull-kubebuilder-e2e-k8s-1-35-0

Details

In response to this:

/override pull-kubebuilder-e2e-k8s-1-35-0
/override pull-kubebuilder-e2e-k8s-1-34-0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit 6ef756b into kubernetes-sigs:master Feb 9, 2026
38 checks passed
@camilamacedo86 camilamacedo86 deleted the helm-makefile-add branch February 9, 2026 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-blocker size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Helm deployment targets to Makefile when using helm plugin

3 participants